Skip to content

Python 3: Fix wrong indent level causing loading of espeak variants to fail - #9920

Merged
feerrenrut merged 1 commit into
nvaccess:threshold_py3_stagingfrom
BabbageCom:espeakVariants
Jul 12, 2019
Merged

Python 3: Fix wrong indent level causing loading of espeak variants to fail#9920
feerrenrut merged 1 commit into
nvaccess:threshold_py3_stagingfrom
BabbageCom:espeakVariants

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Link to issue number:

Fixes mistake introduced in #9853

Summary of the issue:

As part of #9853, I wrapped parsing espeak variant files in a try/except block. However, it turns out that I forgot to add one extra tab to the start of a line that basically caused every variant to be ignored.

Description of how this pull request fixes the issue:

Added one extra tab.

Testing performed:

Tested all is well.

Known issues with pull request:

None

C

@LeonarddeR
LeonarddeR requested a review from feerrenrut July 12, 2019 14:19
@feerrenrut
feerrenrut merged commit ed15de9 into nvaccess:threshold_py3_staging Jul 12, 2019
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jul 12, 2019
@DrSooom

DrSooom commented Jul 13, 2019

Copy link
Copy Markdown

@LeonarddeR: You cut the headline "Change log entry" in the PR description, which content is also "None" here. (I just mentioned this due to historical information reasons.)

@Brian1Gaff

Brian1Gaff commented Jul 14, 2019 via email

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants