Python 3: Fix several local overrides of range function - #9912
Merged
feerrenrut merged 1 commit intoJul 12, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
In several cases in our code base, we are using
rangeas a name of a local attribute or function parameter. In at least one case (uia_getBoundingRectsFromUIARange, this fails, as we are also calling the range function in that method.Description of how this pull request fixes the issue:
Look for every instance of
rangeas a local attribute. In most cases, rename it to textRange.I started with the following regex computed by @feerrenrut:
(,\W?|\W)range\W?[,)=]I also used
\Wrange[.]\wto dig up some missed cases that weren't pick up by the first regex.Testing performed:
Tested that NVDA still starts and works as epxected. It is undoable to test every change, therefore careful review should be performed, possibly with the assistance of a linter.
Known issues with pull request:
None
Change log entry:
None