MoveFileEx: catch WindowsError instead of WinError - #9876
Merged
feerrenrut merged 5 commits intoJul 11, 2019
Conversation
Collaborator
|
I don't think WinError was ever an exception. Should have been WindowsError, which is an alias of OSError on Python 3. |
Contributor
Author
|
Hi, ctypes.WinError was just a function after all, and as for WindowsError, confirmed that this is an alias (editing). Thanks.
|
Comment from Leonard de Ruijter (Babbagecom): WindowsError is an alias of OSError in Python 3, so just use this unless real-life testing shows OSError must be used.
josephsl
changed the title
Contributor
|
Can you confirm that this will put the windows error code in the log please? |
Contributor
Author
|
Hi, I’ll add exc_info parameter since error code isn’t logged yet. Thanks.
|
…ge when MoveFileEx fails. Comment from Reef Turner (NV Access): add exception traceback info for WindowsError.
LeonarddeR
approved these changes
Jul 11, 2019
Collaborator
|
@feerrenrut: I think this is important to go into threshold_py3_staging before merging it into threshold. It is currently preventing me from updating a copy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow-up to #9847
Summary of the issue:
In installer, MoveFileEx catches wrong exception.
Description of how this pull request fixes the issue:
Instead of catching WinError, catch WindowsError (an alias of OSError in Python 3).
Testing performed:
Tested in Python 3 interpreter and NvDA console.
Known issues with pull request:
None
Change log entry:
None