Update check/Python 3: convert update check resource from bytes to Unicode - #9837
Merged
michaelDCurran merged 1 commit intoJun 28, 2019
Merged
Conversation
…s make it Unicode. Re nvaccess#9819. Update check resource is encoded as bytes, causing a type error to be thrown if trying to make a key:val out of it. Thus convert this into Unicode before splitting into key:val.
michaelDCurran
approved these changes
Jun 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9819
Summary of the issue:
Update check resource is presented as bytes-like object.
Description of how this pull request fixes the issue:
Convert resource to Unicode before splitting into key:val pairs.
Testing performed:
Tested to make sure update check facility returns update check resource as before and presents appropriate message.
Known issues with pull request:
None
Change log entry:
None