Python 3: Update BRLTTY driver - #9821
Merged
Merged
Conversation
LeonarddeR
marked this pull request as ready for review
June 27, 2019 09:17
Collaborator
Author
|
It looks like @sthibaul is a pretty active Python binding developer nowadays. Also a cc to @DaveMielke |
feerrenrut
approved these changes
Jul 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
The BRLTTY driver is currently not compatible with Python 3.
Description of how this pull request fixes the issue:
This pr adds Python 3 compatibility. I also added model support to input gestures, so it should be possible to add specific gestures for specific BRLTTY drivers.
Testing performed:
Tested with BRLTTY 6.0 with a Handy Tech display. Unfortunately, I got very mixed results. SOmetimes, the driver just initialized correctly, sometimes the brltty process just crashes. I've also seen this with older versions of BRLTTY and NVDA though. I'm under the impression that the Python wrapper has some issues, but up until now, I haven't got official replies from the BRLTTY developers on my request to provide an official build of the bindings for python 3.7
Known issues with pull request:
The current driver is far from stable, but it wasn't stable before aanyway. This pr at leasts makes it somehow work on Python 3.
Change log entry:
None