Python 3/urllib: imports, timeout - #9820
Merged
michaelDCurran merged 5 commits intoJun 26, 2019
Merged
Conversation
…lib. Re nvaccess#9818. If one imports urllib in Python 3, only the bare bone package will be imported - no parsing, no errors, no opener, etc. Thus import both urllib.request and urllib.parse 9although just importing urllib.request will then load other parts of this package, imported both in update check module for sake of completeness).
…. Re nvaccess#9818. In Python 3, timeout is specified as part of urllib.request.urlopen function. Therefore move the code around and the accompanying comment for nvaccess#2352.
LeonarddeR
approved these changes
Jun 26, 2019
michaelDCurran
approved these changes
Jun 26, 2019
This was referenced Jun 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9818
Summary of the issue:
Update check functionality does not work due to incomplete imports.
Description of how this pull request fixes the issue:
Edited update check module:
Testing performed:
Tested with a custom build of Python 3 staging branch (with update version type specified) to simulate update check and via Python 3 interepreter.
Known issues with pull request:
More to be uncovered as update check module is converted.
Change log entry:
None