Update miscDeps to contain new brlApi module - #9812
Merged
Merged
Conversation
Member
Author
|
I would suggest we merge this as soon as we can, even before checking braille drivers, as this is the last thing blocking this branch from performing a full appveyor build. Successful builds would be a very good thing for validating future prs. |
LeonarddeR
approved these changes
Jun 26, 2019
LeonarddeR
left a comment
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
Could you also update the version in the readme to 0.7.0?
This was referenced Jun 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
The brlApi module in miscDeps is for Python 2.7. Not only is it the wrong Python major version, but the worse issue is that it depends upon msvcrt90 rather than msvcrt140 (like Python 3.7). Mixing different crts in the same process is not recommended and is dangerous.
Description of how this pull request fixes the issue:
Update miscDeps to latest master which contains the updated brlApi for Python 3.7. See pr nvaccess/nvda-misc-deps#14.
Testing performed:
Known issues with pull request:
The brlTty braille Display driver has not at all been tested. There may be secondary issues with the changes to brlApi. However, other braille dirvers in the conversion to Python3 have not really been tested either, and most importantly this stops us loading an old crt into our process causing a freeze/crash.
Change log entry:
None.