System tests/Python 3: syntax and imports - #9801
Merged
michaelDCurran merged 3 commits intoJun 24, 2019
Merged
Conversation
…#9798. In Python 3, xmlrpclib and SimleXMLRPCServer are part of a unified xmlrpc module (the former is xmlrpc.client and the latter is xmlrpc.server). Thus combine the imports.
michaelDCurran
approved these changes
Jun 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9798
Summary of the issue:
Converted system tests suite to Python 3.
Description of how this pull request fixes the issue:
Changes made:
Testing performed:
Tested with Python 3 source code version of NVDA and made sure it ran to successful completion (consulting the test log, for instance).
Known issues with pull request:
Due to app module handler/does app module exist function exception, tests will fail.
Change log entry:
None