Python 3: Write syntax errors and tracebacks to python console - #9767
Merged
michaelDCurran merged 1 commit intoJun 21, 2019
Merged
Conversation
Contributor
|
Hi, Working as advertised. Thanks. |
michaelDCurran
approved these changes
Jun 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9073
Summary of the issue:
In python 3, code.InteractiveConsole.showtraceback/showsyntaxerror will print output to sys.excepthook instead of directly to the console. This results in tracebacks being printed to the NVDA log instead of to our python console.
Description of how this pull request fixes the issue:
Inspired by how we implement the push method, showtraceback and showsyntaxerror now save sys.excepthook, restore it to sys.excepthook call super and then set it back to the initial value before calling the show method.
Testing performed:
Tested that syntax errors and tracebacks generated on the python console are shown as in NVDA on Python 2.
Known issues with pull request:
None