Python3: base virtualBuffer: coerce attribute values to a string before escaping for regular expression - #9759
Merged
Conversation
josephsl
approved these changes
Jun 16, 2019
josephsl
left a comment
josephsl
left a comment
Contributor
There was a problem hiding this comment.
Yep, working in Firefox. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
When trying to read content in virtualBuffers with Python3, an AttributeError is raised as int does not have an attribute: translate.
Description of how this pull request fixes the issue:
When preparing attribute values for a regular expression for finding attributes, make sure to coerce each value to a string before escaping symbols.
Testing performed:
Ran NVDA and read a virtualBuffer document and AttributeError was no longer raised.
Known issues with pull request:
None.
Change log entry:
None.
Section: New features, Changes, Bug fixes