Python 3: use native metaclass definition syntax - #9753
Merged
michaelDCurran merged 9 commits intoJun 16, 2019
Conversation
Python 2 classes can specify metaclasses via __metaclass__ attribute, whereas a metaclass keyword argument is required in Python 3. Thus use Python 3 native syntax for specifying metaclasses.
…ass syntax is used.
michaelDCurran
approved these changes
Jun 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Changes metaclass definition syntax to follow Python 3 format.
Description of how this pull request fixes the issue:
Change the metaclass definition of the form "metaclass = metaclass" to "class class(bases, metaclass=metaclass)".
Steps:
Also, as part of this, six.with_metaclass import has been removed from modules that uses it.
Testing performed:
Tested with Python 2 and 3 versions of NVDA, testing each time a module has been modified to make sure no regressions are introduced.
Known issues with pull request:
None
Change log entry:
None