Python3: import HRESULT from comtypes instead of ctypes.wintypes

[michaelDCurran]

Link to issue number:

None.

Summary of the issue:

In Python3, HRESULT is no longer available in ctypes.wintypes.
There is just one file in our code base that gets it from there. This should be changed to import from comtypes.

Description of how this pull request fixes the issue:

objidl.py: import HRESULT from comtypes rather than ctypes.wintypes.

Testing performed:

objidl successfully imports when starting NVDA.

Known issues with pull request:

None.

Change log entry:

None.

Section: New features, Changes, Bug fixes

[josephsl]

Hi, oops, thanks for catching this import oversight. From: Michael Curran <notifications@github.com> Sent: Friday, June 14, 2019 8:49 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: [nvaccess/nvda] import HRESULT from comtypes instead of ctypes.wintypes (#9745) Link to issue number: None. Summary of the issue: In Python3, HRESULT is no longer available in ctypes.wintypes. There is just one file in our code base that gets it from there. This should be changed to import from comtypes. Description of how this pull request fixes the issue: objidl.py: import HRESULT from comtypes rather than ctypes.wintypes. Testing performed: objidl successfully imports when starting NVDA. Known issues with pull request: None. Change log entry: None. Section: New features, Changes, Bug fixes

…

_____ You can view, comment on, or merge this pull request online at: #9745 Commit Summary * Convert all usage of unichr to chr. * Replace basestring with str. * Remove usage of unicode() which is not available in Python3. * Revert changes to braille related files as these will be handled in a separate pr. * Address review comments. * Merge branch 'py3_unichr' into threshold_py3_staging * objidl: HRESULT is no longer available in ctypes.wintypes. Get it from comtypes. File Changes * M source/NVDAObjects/IAccessible/MSHTML.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-0> (2) * M source/NVDAObjects/IAccessible/__init__.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-1> (16) * M source/NVDAObjects/IAccessible/ia2TextMozilla.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-2> (2) * M source/NVDAObjects/IAccessible/mozilla.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-3> (2) * M source/NVDAObjects/IAccessible/winword.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-4> (2) * M source/NVDAObjects/UIA/edge.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-5> (4) * M source/NVDAObjects/UIA/wordDocument.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-6> (2) * M source/NVDAObjects/__init__.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-7> (20) * M source/NVDAObjects/window/edit.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-8> (3) * M source/NVDAObjects/window/excel.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-9> (2) * M source/NVDAObjects/window/scintilla.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-10> (5) * M source/NVDAObjects/window/winword.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-11> (2) * M source/XMLFormatting.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-12> (4) * M source/addonHandler/__init__.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-13> (11) * M source/api.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-14> (4) * M source/appModuleHandler.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-15> (14) * M source/appModules/msnmsgr.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-16> (2) * M source/appModules/powerpnt.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-17> (2) * M source/appModules/winamp.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-18> (6) * M source/baseObject.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-19> (2) * M source/browseMode.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-20> (9) * M source/buildVersion.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-21> (2) * M source/characterProcessing.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-22> (2) * M source/compoundDocuments.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-23> (2) * M source/config/__init__.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-24> (20) * M source/contentRecog/uwpOcr.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-25> (2) * M source/core.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-26> (2) * M source/displayModel.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-27> (22) * M source/globalCommands.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-28> (16) * M source/gui/settingsDialogs.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-29> (2) * M source/inputCore.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-30> (18) * M source/installer.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-31> (2) * M source/keyboardHandler.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-32> (6) * M source/languageHandler.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-33> (2) * M source/louisHelper.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-34> (4) * M source/mathPres/__init__.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-35> (10) * M source/nvda.pyw <https://github.com/nvaccess/nvda/pull/9745/files#diff-36> (4) * M source/nvda_slave.pyw <https://github.com/nvaccess/nvda/pull/9745/files#diff-37> (2) * M source/nvwave.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-38> (12) * M source/objidl.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-39> (4) * M source/oleacc.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-40> (2) * M source/scriptHandler.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-41> (3) * M source/speech/__init__.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-42> (32) * M source/speech/commands.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-43> (4) * M source/speechViewer.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-44> (2) * M source/speechXml.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-45> (12) * M source/synthDriverHandler.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-46> (2) * M source/synthDrivers/_espeak.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-47> (30) * M source/synthDrivers/espeak.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-48> (13) * M source/synthDrivers/oneCore.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-49> (6) * M source/synthDrivers/sapi4.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-50> (2) * M source/synthDrivers/sapi5.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-51> (2) * M source/textInfos/__init__.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-52> (6) * M source/textInfos/offsets.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-53> (10) * M source/ui.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-54> (15) * M source/virtualBuffers/MSHTML.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-55> (2) * M source/virtualBuffers/__init__.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-56> (16) * M source/winConsoleHandler.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-57> (2) * M source/winKernel.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-58> (2) * M source/winUser.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-59> (2) * M source/windowUtils.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-60> (8) * M tests/unit/textProvider.py <https://github.com/nvaccess/nvda/pull/9745/files#diff-61> (2) Patch Links: * https://github.com/nvaccess/nvda/pull/9745.patch * https://github.com/nvaccess/nvda/pull/9745.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#9745?email_source=notifications&email_token=AB4AXEE3IJPR6RVZPA3B5B3P2RREFA5CNFSM4HYOFPD2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZVSLVQ> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4AXEH2SSPINQBMO4FQFVDP2RREFANCNFSM4HYOFPDQ> .

[josephsl]

Yep, thanks for taking care of this.