Windows Console Handler: use floor division assignment operator when calculating coordinates - #9737
Merged
michaelDCurran merged 1 commit intoJun 13, 2019
Conversation
nvaccess#9641. When calculating console coordinates, Python 2 returns integers but Python 3 returns a float, caused by division assignment operator. Thus use //= instead of /= to guarantee integers. This also resolves backspacing error seen with wrong coordinate type.
michaelDCurran
approved these changes
Jun 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Another fix for #9641
Summary of the issue:
In Windows Console handler, coordinate calculation returns float instead of integer, and backspace doesn't work.
Description of how this pull request fixes the issue:
Changed classic division assignment (/=) to floor division assignment (//=) to guarantee integers.
Steps:
Testing performed:
Tested with a binary build of this PR and ensured that console handling was working (tested with Command Prompt and WSL/Ubuntu).
Known issues with pull request:
None
Change log entry:
None