Python 3: Fix use of subprocess - #9716
Merged
michaelDCurran merged 2 commits intoJun 11, 2019
Merged
Conversation
michaelDCurran
approved these changes
Jun 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
By default, the subprocess module outputs stdout in a bytes object. However, in several cases, we want to fetch strings from this output.
Description of how this pull request fixes the issue:
Provide the new text keyword argument to subprocess function calls. In the case of appx/sconscript, switch to subprocess.run(check=True) instead of subprocess.check.
Also, several uses of subprocess.list2cmdline where related to the use of shellapi.ShellExecute. I also looked at shellapi.ShellExecute as part of this and removed all unnecessary and broken calls of decode on unicode strings.
Testing performed:
T.b.d. I don't know of a good way to test the appx code locally.
Known issues with pull request:
None known