Python 3: use threading instead of thread. - #9713
Merged
Merged
Conversation
LeonarddeR
approved these changes
Jun 11, 2019
LeonarddeR
left a comment
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
This is likely to become a gotcha for add-on authors that use the thread module.
feerrenrut
approved these changes
Jun 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
In Python3, the thread module is no longer available. The threading module should be used instead.
Description of how this pull request fixes the issue:
Replace use of the thread module with threading. We only used thread.get_ident, which also exists in threading.
Testing performed:
tbd.
Known issues with pull request:
None.
Change log entry:
None.
Section: New features, Changes, Bug fixes