SAPI 5: percent to rate/pitch must return an integer - #9699
Merged
michaelDCurran merged 1 commit intoJun 9, 2019
Merged
Conversation
… Re nvaccess#9641. Runtime test result: SAPI5 synth driver did not load in Python 3 mode because percentage to rate/pitch were returning floats instead of integers. This has been corrected.
josephsl
force-pushed
the
py3divisionOperatorSapi5
branch
from
June 8, 2019 22:22
360b34c to
88724bc
Compare
michaelDCurran
approved these changes
Jun 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None, although a follow-up to a previous division operator pull request
Summary of the issue:
SAPI 5 synth cannot be used in Python 3 mode because pitch/rate is seen as a float.
Description of how this pull request fixes the issue:
Changed one slash to two slashes in percent to pitch/rate methods to make sure these values are returned as integers.
Testing performed:
Tested with source code copy (Python 2 and 3) and comparing results of these method calls.
Known issues with pull request:
None
Change log entry:
None