Python 3: except exception, e -> except as e - #9698
Merged
michaelDCurran merged 6 commits intoJun 9, 2019
Merged
Conversation
In Python 2, the exception statement of the form 'except exception, e' was acceptable, no longer the case in Python 3 (requires 'except exception as e'). Thus use the latter in IAccessible objects and others.
…> (configobj.ConfigObjError,UnicodeDecodeError) as e.
feerrenrut
approved these changes
Jun 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Python 3 does not allow excewption assignment of the form "except, e" but rather prefers "except as e".
Description of how this pull request fixes the issue:
Edit all instances of the former syntax to the new one.
Steps:
Testing performed:
Tested with Python 2 and 3 interpreters, along with source code copies.
Known issues with pull request:
None, although there is one instance where UnicodeDecodeError is raised, which may indicate Python 2 assumptions.
Change log entry:
None