Update Scons build environment to run on Python 3 - #9667
Merged
michaelDCurran merged 13 commits intoJun 11, 2019
Conversation
Member
|
This is still marked as draft. As depedencies are now updated in threshold_py3_staging, is this ready to be reviewed? |
added 10 commits
June 10, 2019 12:30
* Remove obsolete _winreg import * No longer pass unicode=True to gettext.install
* comInterfaces_sconscript: iteritems>items * comInterfaces_sconscript: basestring>str * nvdaHelper/archBuild_sconscript: xrange>range * Liblouis sconscript: file>open * cldrDict_sconscript: iteritems>items
…e picked up correctly by scons
Collaborator
Author
michaelDCurran
approved these changes
Jun 11, 2019
LeonarddeR
marked this pull request as ready for review
June 11, 2019 06:31
Collaborator
Author
|
I think this is readdy. I merged in threshold_py3_staging and changed the readme to mention that devDocs is currently not supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, this is a work in progress. This pull request is merely there for ease of following the progress of this work. It will at least require one rebase on threshold, since it contains code from #9630 and #9648 to work in a sensible way.
Link to issue number:
First pr for #9638
Summary of the issue:
The current SCons build environment doesn't work on Python 3.
Description of how this pull request fixes the issue:
Updates several scons scripts to work with Python 3. A more in depth description will follow when this is finished.
Testing performed:
Todo
Known issues with pull request:
None
Change log entry:
None