Fix up user-facing Remote Access terminology - #17943
Conversation
CyrilleB79
left a comment
There was a problem hiding this comment.
Here are various comments.
- Translators comments: some of them still use remote or NVDA remote.
- Other comments (code comment): idem
Maybe you missed them. Searching the whole code could be better than doing it on a diff? I have flagged some of them but there are more of them.
I have also made other little remarks. If you find them off-topic, let me know and I'll add them in a separate issue or PR if needed.
|
Sorry for the close/reopen mess I made there. |
|
"Mute remote" is still there, for "Mute remote computer". But maybe in menus, we want to keep something very short. Unfortunately, to translate (French), we'll need to make something much longer. English language has the capability to precisely express an idea with very few words, but other languages are not so good at it... |
Co-authored-by: Sean Budd <sean@nvaccess.org>
Co-authored-by: Sean Budd <sean@nvaccess.org>
Co-authored-by: Sean Budd <sean@nvaccess.org>
…18038) Summary of the issue: In the user guide section for the Remote Access automatic connection mode, the definitions for "Control another computer" and "Allow this computer to be controlled" were swapped. Description of user facing changes The definitions have been swapped, so they are now correctly paired. "machine" has been replaced with "computer" per Fix up user-facing Remote Access terminology #17943. Description of development approach Modify the table in user_docs/en/userGuide.md.
Link to issue number:
Fixes #17815
Summary of the issue:
NVDA's new Remote Access feature currently uses inconsistent terminology.
Description of user facing changes
Remote Access:
Description of development approach
Generated a pot file, and searched for the word "remote" therein. If it was referring to Remote Access, and some other name was used, replaced it with Remote Access.
Searched for the word "remote" in the user guide and edited as appropriate. Also did a full readthrough of the remote section.
Reviewed the strings in the settings dialog, menu, and cues explicitly and edited as appropriate.
Calculated the diff
1b4a28d4d...9833d7812. Searched in it for newly introduced translator comments, and edited them if related to Remote Access and I thought they were unclear.Calculated the diff
9833d7812...42aaea791. Reviewed it for any changed strings that used gettext (_(...)), and changed to use pgettext (pgettext("remote", ...)).Testing strategy:
pre-commit.
Unit tests.
Checking the generated pot file.
Known issues with pull request:
The remote section of the user guide still needs some TLC, however I believe this is best worked through in a separate PR with input from @qchristenson.
Code Review Checklist:
@coderabbitai summary