Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert message dialog API #17561

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Revert message dialog API #17561

merged 1 commit into from
Dec 20, 2024

Conversation

SaschaCowley
Copy link
Member

Reverts PR

Reverts #17304

Issues fixed

Fixes #17560
Fixes #17553

Issues reopened

Reopens #13007
Reopens #12344
Reopens #12353

Reason for revert

This PR broke two important NVDA functions, and there is insufficient time before the Christmas/New Years break to fix the issues, so we are temporarily reverting so that alphas work over the break:

  • The CRFT no longer works, as gui.message.MessageDialog's inheritance from ContextHelpMixin was accidentally removed.
  • Update checking no longer works, as runScriptModalDialog was modified to increment and decrement _messageBoxCounter, but UpdateAskInstallDialog attempts to restart NVDA before it has been closed, so the update fails as NVDA appears to be in an unsafe state.

Can this PR be reimplemented? If so, what is required for the next attempt

Yes:

  • Fix MessageDialog so it inherits from ContextHelpMixin correctly.
  • Either:
    • Restore the older, less safe behaviour of runScriptModalDialog; or
    • Re-implement the update check code so it does not try to exit NVDA while a modal dialog is open.

@SaschaCowley SaschaCowley requested a review from a team as a code owner December 20, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It seems that the registration tool is not working. cannot update to current alpha
2 participants