Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts PR
Reverts #17304
Issues fixed
Fixes #17560
Fixes #17553
Issues reopened
Reopens #13007
Reopens #12344
Reopens #12353
Reason for revert
This PR broke two important NVDA functions, and there is insufficient time before the Christmas/New Years break to fix the issues, so we are temporarily reverting so that alphas work over the break:
gui.message.MessageDialog
's inheritance fromContextHelpMixin
was accidentally removed.runScriptModalDialog
was modified to increment and decrement_messageBoxCounter
, butUpdateAskInstallDialog
attempts to restart NVDA before it has been closed, so the update fails as NVDA appears to be in an unsafe state.Can this PR be reimplemented? If so, what is required for the next attempt
Yes:
MessageDialog
so it inherits fromContextHelpMixin
correctly.runScriptModalDialog
; or