Network Resources #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilding runnable, ucx and host memory resources
ryanolson
added
improvement
Closed
drobison00
requested changes
Jun 30, 2022
|
@drobison00 - marked all the "add top-level descriptions" as resolved as i completed them. Added #109 to add test coverage. It will be easier for me to see what needs more coverage when #105 is merged. |
drobison00
approved these changes
Jul 2, 2022
|
@gpucibot merge |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will:
memory_resourceobject used to the bare minimum until rapidsai/rmm and libcudacxx have a generalizedmemory_resourceresources::Manageris the component that constructs and destructs resources in the proper sequence. All runnable resources will be completed and joined whenresource::Manageris destructed. The only type of object allowed to out live theresource::Managerare data/memory object. This is because they are ultimately backed by malloc/cudaMallocHost/cudaMalloc which are persistent resources throughout the life of the application. Data created by these resources with the pipeline and transfered back to the user application should outlive theExecutor/resources::Manager.See [/src/internal/resources/manager.hpp](resources::Manager definition) and follow the deconstruction sequence, i.e. the reverse order of the member variables as defined in the header.
Completion of the PR should:
tests/test_memory.cpp#58