Add flake8, yapf, and isort pre-commit hooks.

.pre-commit-config.yaml

@@ -6,6 +6,24 @@ repos:
         hooks:
             - id: rapids-dependency-file-generator
               args: ["--clean"]
+      - repo: https://github.com/PyCQA/isort
+        rev: 5.12.0
+        hooks:
+              - id: isort
+                args: ["--settings-file=./python/setup.cfg"]
+                files: ^python/
+      - repo: https://github.com/PyCQA/flake8
+        rev: 6.1.0
+        hooks:
+              - id: flake8
+                args: ["--config=./python/setup.cfg"]
+                files: ^python/
+      - repo: https://github.com/google/yapf
+        rev: v0.40.2
+        hooks:
+              - id: yapf
+                args: ["--style", "./python/setup.cfg"]
+                files: ^python/
 
 default_language_version:
       python: python3

ci/githooks/pre-commit

@@ -41,6 +41,5 @@ export CHANGED_FILES=$(GIT_DIFF_ARGS="--cached --name-only" get_modified_files)
 
 if [[ "${CHANGED_FILES}" != "" ]]; then
    run_and_check "python3 ci/scripts/copyright.py --git-diff-staged --update-current-year --verify-apache-v2 --git-add"
-   run_and_check "ci/scripts/python_checks.sh"
    SKIP_CLANG_TIDY=1 SKIP_IWYU=1 run_and_check "ci/scripts/cpp_checks.sh"
 fi

ci/scripts/github/checks.sh

@@ -36,8 +36,5 @@ ${MRC_ROOT}/ci/scripts/version_checks.sh
 rapids-logger "Running C++ style checks"
 ${MRC_ROOT}/ci/scripts/cpp_checks.sh
 
-rapids-logger "Runing Python style checks"
-${MRC_ROOT}/ci/scripts/python_checks.sh
-
 rapids-logger "Checking copyright headers"
 python ${MRC_ROOT}/ci/scripts/copyright.py --verify-apache-v2 --git-diff-commits ${CHANGE_TARGET} ${GIT_COMMIT}

conda/environments/all_cuda-118_arch-x86_64.yaml

@@ -42,6 +42,7 @@ dependencies:
 - llvmdev=16
 - ninja=1.10
 - nlohmann_json=3.9
+- numactl-libs-cos7-x86_64
 - numpy>=1.21
 - pkg-config=0.29
 - pre-commit

conda/environments/ci_cuda-118_arch-x86_64.yaml

@@ -21,7 +21,6 @@ dependencies:
 - cuda-version=11.8
 - cxx-compiler
 - doxygen=1.9.2
-- flake8
 - gcovr=5.0
 - glog=0.6
 - graphviz=3.0
@@ -33,6 +32,7 @@ dependencies:
 - librmm=23.06
 - ninja=1.10
 - nlohmann_json=3.9
+- numactl-libs-cos7-x86_64
 - pkg-config=0.29
 - pre-commit
 - pybind11-stubgen=0.10
@@ -42,5 +42,4 @@ dependencies:
 - python=3.10
 - scikit-build>=0.17
 - ucx=1.14
-- yapf
 name: ci_cuda-118_arch-x86_64

dependencies.yaml

@@ -63,6 +63,7 @@ dependencies:
           - librmm=23.06
           - ninja=1.10
           - nlohmann_json=3.9
+          - numactl-libs-cos7-x86_64
           - pkg-config=0.29
           - pybind11-stubgen=0.10
           - python=3.10
@@ -84,17 +85,17 @@ dependencies:
           - clang=16
           - clangdev=16
           - clangxx=16
+          - flake8
           - gdb
           - libclang-cpp=16
           - libclang=16
           - llvmdev=16
+          - yapf
 
   code_style:
     common:
       - output_types: [conda]
         packages:
-          - flake8
-          - yapf
           - include-what-you-use=0.20
 
   testing:

docs/quickstart/python/mrc_qs_python/_version.py

@@ -29,8 +29,7 @@
 import re
 import subprocess
 import sys
-from typing import Callable
-from typing import Dict
+from typing import Callable, Dict
 
 
 def get_keywords():

docs/quickstart/python/mrc_qs_python/ex02_reactive_operators/run.py

@@ -15,9 +15,10 @@
 
 import dataclasses
 
-import mrc
 from mrc.core import operators as ops
 
+import mrc
+
 
 @dataclasses.dataclass
 class MyCustomClass:

docs/quickstart/python/versioneer.py

@@ -286,8 +286,7 @@
 import re
 import subprocess
 import sys
-from typing import Callable
-from typing import Dict
+from typing import Callable, Dict
 
 
 class VersioneerConfig: