Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8, yapf, and isort pre-commit hooks. #420

Merged
merged 9 commits into from
Dec 15, 2023

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Dec 7, 2023

Adds falke8, yapf, and isort pre-commit hooks.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@cwharris cwharris requested review from a team as code owners December 7, 2023 23:16
@cwharris cwharris added improvement Improvement to existing functionality non-breaking Non-breaking change labels Dec 7, 2023
dependencies.yaml Show resolved Hide resolved
ci/scripts/python_checks.sh Show resolved Hide resolved
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #420 (723b3f4) into branch-24.03 (dbbdc7c) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-24.03     #420   +/-   ##
=============================================
  Coverage         74.00%   74.00%           
=============================================
  Files               394      394           
  Lines             13955    13955           
  Branches           1054     1053    -1     
=============================================
+ Hits              10327    10328    +1     
+ Misses             3628     3627    -1     
Flag Coverage Δ
cpp 70.48% <ø> (+<0.01%) ⬆️
py 42.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbbdc7c...723b3f4. Read the comment docs.

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit fdc0fbe into nv-morpheus:branch-24.03 Dec 15, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants