Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup top-level forward.hpp and types.hpp #292

Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Feb 21, 2023

  • Remove forward declares for classes that no longer exist, or no longer exist in the top-level mrc namespace.
  • Remove duplicate entries.
  • Forward-declare structs as structs.
  • Fix casing of CpuSet & NumaSet structs.
  • Remove unused type-aliases from types.hpp, this could be a potentially breaking change if any users were using these types.

fixes #291

…r exist in the top-level mrc namespace.

Forward-declare structs as structs.
Fix casing of CpuSet & NumaSet structs.
@dagardner-nv dagardner-nv requested a review from a team as a code owner February 21, 2023 22:20
@dagardner-nv dagardner-nv added bug Something isn't working breaking Breaking change 3 - Ready for Review labels Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #292 (0f78454) into branch-23.03 (7a6ea6a) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.03     #292      +/-   ##
================================================
+ Coverage         72.95%   72.98%   +0.03%     
================================================
  Files               381      381              
  Lines             13117    13117              
  Branches            992      991       -1     
================================================
+ Hits               9569     9573       +4     
+ Misses             3548     3544       -4     
Flag Coverage Δ
cpp 68.73% <ø> (+0.02%) ⬆️
py 41.04% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cpp/mrc/src/internal/system/partitions.cpp 78.94% <0.00%> (+0.75%) ⬆️
cpp/mrc/src/internal/resources/manager.cpp 91.91% <0.00%> (+1.01%) ⬆️
cpp/mrc/src/internal/memory/host_resources.cpp 74.28% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a6ea6a...0f78454. Read the comment docs.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c509b1c into nv-morpheus:branch-23.03 Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: forwards don't match definitions
2 participants