Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: forwards don't match definitions #291

Closed
2 tasks done
dagardner-nv opened this issue Feb 17, 2023 · 0 comments · Fixed by #292
Closed
2 tasks done

[BUG]: forwards don't match definitions #291

dagardner-nv opened this issue Feb 17, 2023 · 0 comments · Fixed by #292
Assignees
@dagardner-nv
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

23.03

Which installation method(s) does this occur on?

Docker, Conda, Source

Describe the bug.

We have some forward declarations declared with class but the definition is a struct

ex:
in cpp/mrc/include/mrc/forward.hpp we have:

class Cpuset;

but in cpp/mrc/include/mrc/core/bitmap.hpp we have:

struct CpuSet : public Bitmap

This has been compiling and working just fine, but should probably get fixed before it becomes an issue.

Minimum reproducible example

No response

Relevant log output

No response

Full env printout

No response

Other/Misc.

No response

Code of Conduct

  • I agree to follow MRC's Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Feb 17, 2023
@dagardner-nv dagardner-nv self-assigned this Feb 17, 2023
@dagardner-nv dagardner-nv mentioned this issue Feb 21, 2023
Merged
@rapids-bot rapids-bot bot closed this as completed in #292 Mar 8, 2023
rapids-bot bot pushed a commit that referenced this issue Mar 8, 2023
@dagardner-nv
Cleanup top-level forward.hpp and types.hpp (#292)
c509b1c 
* Remove forward declares for classes that no longer exist, or no longer exist in the top-level `mrc` namespace.
* Remove duplicate entries.
* Forward-declare structs as structs.
* Fix casing of `CpuSet` & `NumaSet` structs.
* Remove unused type-aliases from `types.hpp`, this could be a potentially breaking change if any users were using these types.

fixes #291

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Ryan Olson (https://github.com/ryanolson)

URL: #292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup top-level forward.hpp and types.hpp dagardner-nv/MRC
1 participant
@dagardner-nv