Data Plane - Initial P2P and RDMA Get #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilding runnable, ucx and host memory resources
…urce for device memory
ryanolson
added
non-breaking
drobison00
reviewed
Jul 14, 2022
Co-authored-by: Devin Robison <[email protected]>
Co-authored-by: Devin Robison <[email protected]>
drobison00
approved these changes
Jul 26, 2022
|
@gpucibot merge |
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Jul 29, 2022
Enables internal members to query the runtime resources from a `static thread_local` member of the `resources::Manager` This builds on #112 This diff will highlight what's in this PR: pull-request/112...pull-request/113 Appended to this PR is a repo wide update to correct all cpp_checks that are now failing. Authors: - Ryan Olson (https://github.com/ryanolson) - David Gardner (https://github.com/dagardner-nv) Approvers: - Devin Robison (https://github.com/drobison00) URL: #113
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first stage of bring back the data plane to the SRF runtime.
This adds the following to the
data_planenamespace:Callbacks- a struct of static methods used to handle UCX callback on locally initiated UCX transactions, e.g. issuing a tagged send or and RDMA GET.Request- a struct which holds the state of an async transaction. This object holds a bit more data than just a promise/future pair. I figure the API will have two ways to kick off an async transaction, one that takes a ref to aRequestand another that return aRequest. The latter requires a heap allocation, so the former could be used as a subtle optimization for structured concurrency.DataPlaneServerWorkerwhich is the Runnable that drives the UCX worker's progress method which ultimately executes the UCX callbacks. More functionality will be added to this component over time, specifically usingucp_nb_probeto match any incoming events who's payloads were larger than the pre-posted buffers.The remaining work in this PR is moving the ucx tests into the internal tests binary and re-enables the RDMA get test.
This is not a complete implementation of the UCX Data Plane. #144 was created to address the WIP state.