Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Data Plane WIP #144

Open
ryanolson opened this issue Jul 13, 2022 · 0 comments
Open

[FEA] Data Plane WIP #144

ryanolson opened this issue Jul 13, 2022 · 0 comments
Assignees
Labels
feature request New feature or request

Comments

@ryanolson
Copy link
Contributor

Resolution of this issue will finalize the files in the src/internal/data_plane directory.

@ryanolson ryanolson added the feature request New feature or request label Jul 13, 2022
@ryanolson ryanolson added this to the Multi-Node Support milestone Jul 13, 2022
@ryanolson ryanolson self-assigned this Jul 13, 2022
ghost pushed a commit that referenced this issue Jul 26, 2022
This PR is the first stage of bring back the data plane to the SRF runtime.

This adds the following to the `data_plane` namespace:
- `Callbacks` - a struct of static methods used to handle UCX callback on locally initiated UCX transactions, e.g. issuing a tagged send or and RDMA GET.
- `Request` - a struct which holds the state of an async transaction. This object holds a bit more data than just a promise/future pair. I figure the API will have two ways to kick off an async transaction, one that takes a ref to a `Request` and another that return a `Request`. The latter requires a heap allocation, so the former could be used as a subtle optimization for structured concurrency.
- `DataPlaneServerWorker` which is the Runnable that drives the UCX worker's progress method which ultimately executes the UCX callbacks. More functionality will be added to this component over time, specifically using `ucp_nb_probe` to match any incoming events who's payloads were larger than the pre-posted buffers.

The remaining work in this PR is moving the ucx tests into the internal tests binary and re-enables the RDMA get test.

This is not a complete implementation of the UCX Data Plane. #144 was created to address the WIP state.

Authors:
  - Ryan Olson (https://github.com/ryanolson)

Approvers:
  - Devin Robison (https://github.com/drobison00)

URL: #112
@mdemoret-nv mdemoret-nv removed this from the Multi-Node Support milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Todo
Status: In Progress
Development

No branches or pull requests

3 participants