fix: normalize and enforce stdin paths as well #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfly
force-pushed
the
consistent-handling-of-stdin
branch
from
3bc0be7 to
34005f8
Compare
brianmcgee
approved these changes
Oct 12, 2024
|
@jfly rebase and then mark this as ready and we can get it merged |
jfly
force-pushed
the
consistent-handling-of-stdin
branch
from
34005f8 to
241f682
Compare
See numtide#440 for the last attempt to do this because (at the time) this "is the file in the tree root?" check relied upon checking for concrete files in the filesystem. As of numtide@ff3de21, that's longer the case, so we can make this code a bit more consistent.
jfly
force-pushed
the
consistent-handling-of-stdin
branch
from
241f682 to
9ce6522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #440 for the last attempt to
do this because (at the time) this "is the file in the tree root?" check
relied upon checking for concrete files in the filesystem. As of
ff3de21,
that's longer the case, so we can make this code a bit more consistent.