fix: also check if path is in project for --stdin #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--stdin should operate under the same rules as the other walkers.
brianmcgee
approved these changes
Oct 12, 2024
|
I remember now why it worked the way it did before. The stdin path doesn't exist yet. It will be created by the stdin walker when |
jfly
added a commit
to jfly/treefmt
that referenced
this pull request
Oct 12, 2024
See numtide#440 for the last attempt to do this because (at the time) this "is the file in the tree root?" check relied upon checking for concrete files in the filesystem. That's no longer the case, so we can make this code a bit more consistent.
jfly
added a commit
to jfly/treefmt
that referenced
this pull request
Oct 12, 2024
See numtide#440 for the last attempt to do this because (at the time) this "is the file in the tree root?" check relied upon checking for concrete files in the filesystem. That's no longer the case, so we can make this code a bit more consistent.
Hmm... are you sure the stdin walker creates the file? That seems like odd behavior to me, and doesn't seem to be what's happening with the code on #445 removes the requirement that the paths actually exist in order to check that they're under the tree root. Assuming that PR looks good, I've re-implemented @zimbatm's work here over in #446. I don't think it has any issues with missing files. |
jfly
added a commit
to jfly/treefmt
that referenced
this pull request
Oct 12, 2024
See numtide#440 for the last attempt to do this because (at the time) this "is the file in the tree root?" check relied upon checking for concrete files in the filesystem. That's no longer the case, so we can make this code a bit more consistent.
jfly
added a commit
to jfly/treefmt
that referenced
this pull request
Oct 12, 2024
See numtide#440 for the last attempt to do this because (at the time) this "is the file in the tree root?" check relied upon checking for concrete files in the filesystem. As of numtide@ff3de21, that's longer the case, so we can make this code a bit more consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--stdin should operate under the same rules as the other walkers.