-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix migration note for alltrue
and sometrue
#27015
Conversation
@rgommers I see that I took it from the deprecation message added here: 9990f98 I think in:
and
you meant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @mtsokol.
you meant
np.all
andnp.any
, not the Python builtins, right? As the release note states.
Yes indeed. That seemed clear to me even without the np.
- I think all the surrounding notes with the np.
included were written later. Nevertheless, this PR makes it more clear, so in it goes.
alltrue
and sometrue
alltrue
and sometrue
Certainly not a bug I'd say - changed to |
Backporting sounds fine to me, in case we do a 2.0.2 release - label added. |
alltrue
and sometrue
alltrue
and sometrue
Hi @ngoldbaum,
I think I made a mistake in #26517 as pointed out it in astral-sh/ruff#12416.
np.sometrue
andnp.alltrue
should be mapped tonp.any
andnp.all
instead of Python builtinsany
/all
. (It could be also backported).