Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NumPy 2.0 rule for np.alltrue and np.sometrue #12473

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Fix NumPy 2.0 rule for np.alltrue and np.sometrue #12473

merged 3 commits into from
Jul 23, 2024

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Jul 23, 2024

Fixes: #12416

Also to be fixed in NumPy: numpy/numpy#27015

@MichaReiser MichaReiser added the rule Implementing or modifying a lint rule label Jul 23, 2024
@mtsokol
Copy link
Contributor Author

mtsokol commented Jul 23, 2024

There was a typo in anytrue name (should be sometrue). I will adjust the snap file.

@MichaReiser
Copy link
Member

Thanks

@MichaReiser MichaReiser enabled auto-merge (squash) July 23, 2024 08:31
@MichaReiser MichaReiser merged commit f96a3c7 into astral-sh:main Jul 23, 2024
18 checks passed
@mtsokol mtsokol deleted the sometrue-alltrue-fix branch July 23, 2024 08:38
@mtsokol mtsokol mentioned this pull request Jul 23, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPY201: replacing sometrue/alltrue with any/all results in broken code
2 participants
@mtsokol @MichaReiser