Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/1684-broken-icon-links #1701

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Bug/1684-broken-icon-links #1701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a86331
Add error handling on image loading for album covers & thumbnails
waldo121 Sep 17, 2024
69efba4
update snapshots
waldo121 Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions ...ages/app/app/containers/AlbumViewContainer/__snapshots__/AlbumViewContainer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,11 +580,7 @@ exports[`Album view container should display an album 1`] = `
>
<div
class="nuclear cover_container"
>
<img
src="test-file-stub"
/>
</div>
/>
</div>
<div
class="player_controls"
Expand Down Expand Up @@ -747,11 +743,7 @@ exports[`Album view container should show that an album is still loading 1`] = `
>
<div
class="nuclear cover_container"
>
<img
src="test-file-stub"
/>
</div>
/>
</div>
<div
class="player_controls"
Expand Down
21 changes: 3 additions & 18 deletions ...es/app/app/containers/ArtistViewContainer/__snapshots__/ArtistViewContainer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,12 +227,7 @@ exports[`Artist view container should display an artist 1`] = `
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="test-file-stub"
/>
</div>
/>
<div
class="grid_track_table_cell favorite_cell"
data-testid="favorite-cell"
Expand Down Expand Up @@ -323,12 +318,7 @@ exports[`Artist view container should display an artist 1`] = `
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="test-file-stub"
/>
</div>
/>
<div
class="grid_track_table_cell favorite_cell"
data-testid="favorite-cell"
Expand Down Expand Up @@ -419,12 +409,7 @@ exports[`Artist view container should display an artist 1`] = `
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="test-file-stub"
/>
</div>
/>
<div
class="grid_track_table_cell favorite_cell"
data-testid="favorite-cell"
Expand Down
14 changes: 2 additions & 12 deletions ...ages/app/app/containers/DashboardContainer/__snapshots__/DashboardContainer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,12 +733,7 @@ exports[`Dashboard container should display top tracks after going to top tracks
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="top track album cover 1"
/>
</div>
/>
<div
class="grid_track_table_cell favorite_cell"
data-testid="favorite-cell"
Expand Down Expand Up @@ -855,12 +850,7 @@ exports[`Dashboard container should display top tracks after going to top tracks
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="top track album cover 2"
/>
</div>
/>
<div
class="grid_track_table_cell favorite_cell"
data-testid="favorite-cell"
Expand Down
14 changes: 2 additions & 12 deletions ...pp/app/containers/DeezerPlaylistAdapter/__snapshots__/DeezerPlaylistAdapter.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,12 +263,7 @@ exports[`Deezer playlist adapter should display a Deezer playlist 1`] = `
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="test-file-stub"
/>
</div>
/>
<div
class="grid_track_table_cell favorite_cell"
data-testid="favorite-cell"
Expand Down Expand Up @@ -379,12 +374,7 @@ exports[`Deezer playlist adapter should display a Deezer playlist 1`] = `
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="test-file-stub"
/>
</div>
/>
<div
class="grid_track_table_cell favorite_cell"
data-testid="favorite-cell"
Expand Down
52 changes: 8 additions & 44 deletions ...p/app/containers/FavoritesContainer/__snapshots__/FavoritesContainer.tracks.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,7 @@ exports[`Favorite tracks view container should display empty state 1`] = `
>
<div
class="nuclear cover_container"
>
<img
src="test-file-stub"
/>
</div>
/>
</div>
<div
class="player_controls"
Expand Down Expand Up @@ -392,12 +388,7 @@ exports[`Favorite tracks view container should display favorite tracks 1`] = `
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="https://test-track-thumb-url"
/>
</div>
/>
<div
class="grid_track_table_cell text_cell title_cell"
data-testid="title-cell"
Expand Down Expand Up @@ -508,12 +499,7 @@ exports[`Favorite tracks view container should display favorite tracks 1`] = `
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="https://test-track-thumb-url"
/>
</div>
/>
<div
class="grid_track_table_cell text_cell title_cell"
data-testid="title-cell"
Expand Down Expand Up @@ -606,11 +592,7 @@ exports[`Favorite tracks view container should display favorite tracks 1`] = `
>
<div
class="nuclear cover_container"
>
<img
src="test-file-stub"
/>
</div>
/>
</div>
<div
class="player_controls"
Expand Down Expand Up @@ -961,12 +943,7 @@ exports[`Favorite tracks view container should show a popup when a track is clic
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="https://test-track-thumb-url"
/>
</div>
/>
<div
class="grid_track_table_cell text_cell title_cell"
data-testid="title-cell"
Expand Down Expand Up @@ -1077,12 +1054,7 @@ exports[`Favorite tracks view container should show a popup when a track is clic
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="https://test-track-thumb-url"
/>
</div>
/>
<div
class="grid_track_table_cell text_cell title_cell"
data-testid="title-cell"
Expand Down Expand Up @@ -1175,11 +1147,7 @@ exports[`Favorite tracks view container should show a popup when a track is clic
>
<div
class="nuclear cover_container"
>
<img
src="test-file-stub"
/>
</div>
/>
</div>
<div
class="player_controls"
Expand Down Expand Up @@ -1320,11 +1288,7 @@ exports[`Favorite tracks view container should show a popup when a track is clic
>
<div
class="popup_thumb"
>
<img
src="https://test-track-thumb-url"
/>
</div>
/>
<div
class="popup_info"
>
Expand Down
21 changes: 3 additions & 18 deletions .../app/app/containers/LibraryViewContainer/__snapshots__/LibraryViewContainer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,12 +1000,7 @@ exports[`Library view container should display local library in simple list mode
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="local track thumbnail 1"
/>
</div>
/>
<div
class="grid_track_table_cell text_cell title_cell"
data-testid="title-cell"
Expand Down Expand Up @@ -1113,12 +1108,7 @@ exports[`Library view container should display local library in simple list mode
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="local track thumbnail 2"
/>
</div>
/>
<div
class="grid_track_table_cell text_cell title_cell"
data-testid="title-cell"
Expand Down Expand Up @@ -1226,12 +1216,7 @@ exports[`Library view container should display local library in simple list mode
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="local track thumbnail 3"
/>
</div>
/>
<div
class="grid_track_table_cell text_cell title_cell"
data-testid="title-cell"
Expand Down
27 changes: 0 additions & 27 deletions ...ages/app/app/containers/PlayQueueContainer/__snapshots__/PlayQueueContainer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,6 @@ exports[`Play Queue container should display a context popup on right click 1`]
<div
class="thumbnail"
>
<img
src="https://test-track-thumb-url"
/>
<div
class="thumbnail_overlay"
data-testid="queue-item-remove"
Expand Down Expand Up @@ -261,9 +258,6 @@ exports[`Play Queue container should display a context popup on right click 1`]
<div
class="thumbnail"
>
<img
src="https://test-track-thumb-url"
/>
<div
class="thumbnail_overlay"
data-testid="queue-item-remove"
Expand Down Expand Up @@ -320,9 +314,6 @@ exports[`Play Queue container should display a context popup on right click 1`]
<div
class="thumbnail"
>
<img
src="test-file-stub"
/>
<div
class="thumbnail_overlay"
data-testid="queue-item-remove"
Expand Down Expand Up @@ -790,9 +781,6 @@ exports[`Play Queue container should display a context popup on right click for
<div
class="thumbnail"
>
<img
src="https://test-track-thumb-url"
/>
<div
class="thumbnail_overlay"
data-testid="queue-item-remove"
Expand Down Expand Up @@ -849,9 +837,6 @@ exports[`Play Queue container should display a context popup on right click for
<div
class="thumbnail"
>
<img
src="https://test-track-thumb-url"
/>
<div
class="thumbnail_overlay"
data-testid="queue-item-remove"
Expand Down Expand Up @@ -908,9 +893,6 @@ exports[`Play Queue container should display a context popup on right click for
<div
class="thumbnail"
>
<img
src="test-file-stub"
/>
<div
class="thumbnail_overlay"
data-testid="queue-item-remove"
Expand Down Expand Up @@ -1337,9 +1319,6 @@ exports[`Play Queue container should display tracks in the queue 1`] = `
<div
class="thumbnail"
>
<img
src="https://test-track-thumb-url"
/>
<div
class="thumbnail_overlay"
data-testid="queue-item-remove"
Expand Down Expand Up @@ -1396,9 +1375,6 @@ exports[`Play Queue container should display tracks in the queue 1`] = `
<div
class="thumbnail"
>
<img
src="https://test-track-thumb-url"
/>
<div
class="thumbnail_overlay"
data-testid="queue-item-remove"
Expand Down Expand Up @@ -1455,9 +1431,6 @@ exports[`Play Queue container should display tracks in the queue 1`] = `
<div
class="thumbnail"
>
<img
src="test-file-stub"
/>
<div
class="thumbnail_overlay"
data-testid="queue-item-remove"
Expand Down
14 changes: 2 additions & 12 deletions ...pp/app/containers/PlaylistViewContainer/__snapshots__/PlaylistViewContainer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,12 +292,7 @@ exports[`Playlist view container should display a playlist 1`] = `
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="test thumbnail"
/>
</div>
/>
<div
class="grid_track_table_cell favorite_cell"
data-testid="favorite-cell"
Expand Down Expand Up @@ -427,12 +422,7 @@ exports[`Playlist view container should display a playlist 1`] = `
<div
class="grid_track_table_cell thumbnail_cell"
role="cell"
>
<img
class="thumbnail_cell_thumbnail"
src="test thumbnail 2"
/>
</div>
/>
<div
class="grid_track_table_cell favorite_cell"
data-testid="favorite-cell"
Expand Down
Loading
Loading