Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/1684-broken-icon-links #1701

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

waldo121
Copy link
Contributor

@waldo121 waldo121 commented Sep 17, 2024

Fixes #1684

Screenshots
Miniplayer
20240917_16h53m12s_grim
Favorites + Context menu
20240917_16h53m20s_grim
Collapsed Queue items
20240917_18h19m57s_grim
20240917_18h20m04s_grim
Queue items when hovering
20240917_18h20m36s_grim

@waldo121 waldo121 force-pushed the bug/1684-broken-icon-links branch from fae4727 to 69efba4 Compare September 17, 2024 22:11
@waldo121 waldo121 marked this pull request as ready for review September 17, 2024 22:28
@nukeop
Copy link
Owner

nukeop commented Sep 17, 2024

Thanks for fixing this comprehensively. The downside is that images no longer appear in the snapshots, do you know if this can be fixed? In the meantime I will merge this PR.

@nukeop nukeop merged commit a966851 into nukeop:master Sep 17, 2024
8 checks passed
@waldo121
Copy link
Contributor Author

Thanks for fixing this comprehensively. The downside is that images no longer appear in the snapshots, do you know if this can be fixed? In the meantime I will merge this PR.

Looking into it

@waldo121 waldo121 deleted the bug/1684-broken-icon-links branch September 28, 2024 15:03
@waldo121
Copy link
Contributor Author

waldo121 commented Sep 29, 2024

If we use html's <img> error handling instead of react-image we could keep she snapshots. I messed around React-Image, and jest but haven't managed to get the images back in the snapshots using that approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Songs from albums without a picture show broken image icon
2 participants