Support unsigned object GET/HEAD responses #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Jun 19, 2025
cthulhu-rider
commented
- based on and blocked by object: Deprecate verification fields in GET and HEAD responses neofs-api#334
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #719 +/- ##
==========================================
+ Coverage 59.17% 59.19% +0.01%
==========================================
Files 166 166
Lines 20950 20970 +20
==========================================
+ Hits 12397 12413 +16
- Misses 8287 8290 +3
- Partials 266 267 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
get-unsigned
branch
from
44ae535 to
09b6307
Compare
Member
roman-khimov
left a comment
roman-khimov
left a comment
There was a problem hiding this comment.
How about checksums? Can we check them and have an option to disable these checks at the client level?
From nspcc-dev/neofs-api@7dd2d1d. Brought doc changes only. Signed-off-by: Leonard Lyubich <[email protected]>
They are deprecated since nspcc-dev/neofs-api#334. Signed-off-by: Leonard Lyubich <[email protected]>
ID of the object is essentially a checksum of its header. To prevent malicious data substitution or bugs, received headers should be verified against requested IDs. This makes `Client.ObjectHead` method to do it. Signed-off-by: Leonard Lyubich <[email protected]>
Some customers may want to self-check or not check. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
get-unsigned
branch
from
09b6307 to
2d60282
Compare
Follow 9f8ec0c, f3437c5. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
get-unsigned
branch
from
2d60282 to
666fbf8
Compare
roman-khimov
approved these changes
Jun 23, 2025
carpawell
approved these changes
Jun 23, 2025
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 23, 2025
Follow nspcc-dev/neofs-sdk-go#719 in request forwarding case. Refs #3396. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 23, 2025
Continues b283606. Follow nspcc-dev/neofs-sdk-go#719 in request forwarding case. Refs #3396. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 24, 2025
Continues ad60ee5. Follow nspcc-dev/neofs-sdk-go#719 in request forwarding case. Refs #3396. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 25, 2025
Continues f0ce38e. Follow nspcc-dev/neofs-sdk-go#719 in request proxy case. Refs #3396. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 25, 2025
Continues 041cdce. Follow nspcc-dev/neofs-sdk-go#719 in request proxy case. Refs #3396. Signed-off-by: Leonard Lyubich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.