Support unsigned object GET/HEAD responses #3406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
force-pushed
the
unsigned-get
branch
2 times, most recently
from
9dbdea1 to
6369291
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3406 +/- ##
=======================================
Coverage 20.97% 20.97%
=======================================
Files 707 707
Lines 52843 52875 +32
=======================================
+ Hits 11083 11090 +7
- Misses 40962 40989 +27
+ Partials 798 796 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
unsigned-get
branch
7 times, most recently
from
60620b4 to
7b4e082
Compare
cthulhu-rider
force-pushed
the
unsigned-get
branch
2 times, most recently
from
13f8508 to
f1ea991
Compare
New version makes SN, IR and CLI to: - ignore signatures - verify object checksums from object GET/HEAD responses via API client from SDK. Refs #3396. Signed-off-by: Leonard Lyubich <[email protected]>
Follow nspcc-dev/neofs-api#334. Refs #3396. Signed-off-by: Leonard Lyubich <[email protected]>
Continues 041cdce. Follow nspcc-dev/neofs-sdk-go#719 in request proxy case. Refs #3396. Signed-off-by: Leonard Lyubich <[email protected]>
Continue 041cdce for request proxy case. Refs #3396. Signed-off-by: Leonard Lyubich <[email protected]>
Continue debfe6e for object payload. Refs #3396. Signed-off-by: Leonard Lyubich <[email protected]>
Same as f2a770a. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
unsigned-get
branch
from
f1ea991 to
ec7c76e
Compare
roman-khimov
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested S3 and REST GWs require signatures to be presented. Passed tests assert proposed behavior is backward compatible. Note that clients which do not set API version are also served with signatures