-
Notifications
You must be signed in to change notification settings - Fork 50
services/object: use stream API for Get operation
#3466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3466 +/- ##
==========================================
+ Coverage 25.66% 25.70% +0.03%
==========================================
Files 659 659
Lines 49373 49399 +26
==========================================
+ Hits 12673 12698 +25
+ Misses 35694 35691 -3
- Partials 1006 1010 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
57aec91 to
44bc0fb
Compare
bee7074 to
b0e25b8
Compare
b0e25b8 to
a19cf2c
Compare
cthulhu-rider
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
viewed partially, lets discuss these ones first
a19cf2c to
5a26b99
Compare
937f63d to
8b14bf0
Compare
cthulhu-rider
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall
pls try to make more ergonomic diff in initFromChild, currently it has many unrelated changes
8b14bf0 to
12dacaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@End-rey good!
lets cmp performance of 64K and 256K buffers. If there is no growth or it is insignificant, it makes sense to leave 64
and conflicts ofc
12dacaf to
22207c0
Compare
|
@cthulhu-rider I think the last changes is |
|
tests fail |
22207c0 to
0e825a3
Compare
roman-khimov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some high-level statistics to 256K commit message (maybe to the first one as well), we need this to be kept in git log.
97e14e3 to
a45a657
Compare
|
Hmm, some problem with UTs after rebase. |
40bec1c to
16adc2d
Compare
Network API always had a concept of payload stream, FSTree can also provide it now after #3431. So use `GetStream` in object service to enable memory-efficient object retrieval without loading large payloads into memory. Closes #3439. Signed-off-by: Andrey Butusov <[email protected]>
``` Test=get---------Size=4096k---------Thr=15 base: 397 obj/s 64K: 448 obj/s 256K: 539 obj/s ``` Signed-off-by: Andrey Butusov <[email protected]>
Use `apistatus.ErrObjectOutOfRange` instead of `new(apistatus.ObjectOutOfRange)` Signed-off-by: Andrey Butusov <[email protected]>
Closes #3439.