Storage GetStream API
#3532
Storage GetStream API
#3532
Conversation
Signed-off-by: Andrey Butusov <[email protected]>
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3532 +/- ##
==========================================
+ Coverage 24.21% 24.39% +0.17%
==========================================
Files 677 678 +1
Lines 50538 50678 +140
==========================================
+ Hits 12237 12361 +124
- Misses 37311 37324 +13
- Partials 990 993 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pkg/metrics/engine.go
Outdated
| Help: "Engine 'head' operations handling time", | ||
| }) | ||
|
|
||
| streamDuration = prometheus.NewHistogram(prometheus.HistogramOpts{ |
There was a problem hiding this comment.
hm, i look at it and think if it can be useful as a metric that just answers how long we were acquiring an object stream, but not a streaming duration itself. mb that is ok
There was a problem hiding this comment.
reasonable mention, especcially taking into account how similar metrics are split in https://pkg.go.dev/github.com/nspcc-dev/[email protected]/stat#Method. Reader usage duration is very tied to the use-case. For example, with #3439 the data will be copied to the GET channel
so for now we'll start with the call duration, then extend it if necessary
Signed-off-by: Andrey Butusov <[email protected]>
Make `GetStream` API in writecache, shard and engine. Expose `GetStream` metric. Signed-off-by: Andrey Butusov <[email protected]>
Refactor the code for using the storage 'GetStream' in the 'Get' object service to further implement its logic. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
storage-stream-api
branch
from
253009f to
49a0d6f
Compare
Part of #3466.