Skip to content

fix(release): restore packages/devkit/package.json after release #35598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrozenPandaz merged 2 commits into from
May 6, 2026
+6 −1
Merged

fix(release): restore packages/devkit/package.json after release #35598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29c1070
fix(release): restore packages/devkit/package.json after release
FrozenPandaz May 6, 2026
5e798b0
Merge branch 'master' into release-reset-devkit-package-json
FrozenPandaz May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .claude/skills/dist-build-migration/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,11 @@ For example, `devkit-generation.ts` had to be updated to look for `packages/devk

### 13. Update `scripts/nx-release.ts`

If the package has special release handling in `scripts/nx-release.ts` (like devkit's `hackFixForDevkitPeerDependencies`), update any paths from `./dist/packages/<name>/` to `./packages/<name>/`.
Two things to do here:

1. **Add the package to `packagesToReset`.** That array (around `scripts/nx-release.ts:76`) is the snapshot/restore list — every package whose source `package.json` gets mutated by `nx release` (because it now publishes from `packages/<name>/` directly, not `dist/packages/<name>/`) must be in this list. Otherwise the release will leave `packages/<name>/package.json` dirty in the working tree after running. **Easy to forget — and there is no test that catches it.**

2. **Update any package-specific paths.** If the package has special release handling (like devkit's `hackFixForDevkitPeerDependencies`), update any paths from `./dist/packages/<name>/` to `./packages/<name>/`.

### 14. Update imports across the workspace

Expand Down
1 change: 1 addition & 0 deletions scripts/nx-release.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ const VALID_AUTHORS_FOR_LATEST = [
const packagesToReset = [
'packages/angular-rspack',
'packages/angular-rspack-compiler',
'packages/devkit',
'packages/dotnet',
'packages/maven',
'packages/nx',
Expand Down
Loading