fix(release): restore packages/devkit/package.json after release#35598
Merged
FrozenPandaz merged 2 commits intoMay 6, 2026
Merged
Conversation
Devkit was migrated to publish from its source folder (packages/devkit) in nrwl#34946, but it was not added to the packagesToReset snapshot/restore list in scripts/nx-release.ts. As a result, the source package.json is left modified in the working tree after running a release locally. Also note this gotcha in the dist-build-migration skill so future migrations don't forget the same step.
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for nx-dev pending review.Visit the deploys page to approve it
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 5e798b0
☁️ Nx Cloud last updated this comment at |
AgentEnder
approved these changes
May 6, 2026
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
After running
nx-releaselocally,packages/devkit/package.jsonis left modified in the working tree.The
nx-release.tsscript snapshots and restores the sourcepackage.jsonfor every package whose source folder is the publish root (so the temporary edits made duringnx release version— real version, expandedworkspace:*deps, etc. — don't leak into the working tree). The list of those packages lives inpackagesToResetnear the top ofscripts/nx-release.ts.When
@nx/devkitwas migrated to publish from its source folder in #34946, it was not added to that list, so its sourcepackage.jsonis no longer restored.Expected Behavior
packages/devkit/package.jsonis restored to its committed contents afternx-releasefinishes (or is interrupted), matching the behavior already in place fornx,dotnet,maven,angular-rspack, andangular-rspack-compiler.Related Issue(s)
N/A — internal release-tooling fix.