Skip to content

fix(angular-rspack): ensure rebuild chunks emitted summary accurate #34979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrozenPandaz merged 1 commit into from
Mar 24, 2026
Merged

fix(angular-rspack): ensure rebuild chunks emitted summary accurate #34979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/angular-rspack-compiler/src/compilation/setup-compilation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ export const DEFAULT_NG_COMPILER_OPTIONS: ts.CompilerOptions = {
supportJitMode: false,
};

let COMPONENT_STYLESHEET_BUNDLER: ComponentStylesheetBundler | undefined =
undefined;

export async function setupCompilation(
config: Pick<RsbuildConfig, 'mode' | 'source'>,
options: SetupCompilationOptions
Expand Down Expand Up @@ -86,7 +89,7 @@ export async function setupCompilation(
}
}

const componentStylesheetBundler = new ComponentStylesheetBundler(
COMPONENT_STYLESHEET_BUNDLER ??= new ComponentStylesheetBundler(
{
workspaceRoot: options.root,
optimization: config.mode === 'production',
Expand Down Expand Up @@ -116,7 +119,7 @@ export async function setupCompilation(
return {
rootNames,
compilerOptions,
componentStylesheetBundler,
componentStylesheetBundler: COMPONENT_STYLESHEET_BUNDLER,
};
}

Expand Down
30 changes: 23 additions & 7 deletions packages/angular-rspack/src/lib/utils/stats.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ function generateBundleStats(info: {

// Ideally, we should create the logging callback as a factory, but that would need a refactoring.
const runsCache = new Set<string>();
const chunkHashCache = new Map<string, Map<string | number, string>>();

function statsToString(
stats: Stats,
Expand All @@ -125,11 +126,20 @@ function statsToString(
let hasEstimatedTransferSizes = false;

const isFirstRun = !runsCache.has(json.outputPath || '');
const prevHashes =
chunkHashCache.get(json.outputPath || '') ??
new Map<string | number, string>();
const nextHashes = new Map<string | number, string>();

for (const chunk of json.chunks) {
// During first build we want to display unchanged chunks
// but unchanged cached chunks are always marked as not rendered.
if (!isFirstRun && !chunk.rendered) {
const key = chunk.id ?? chunk.names?.[0] ?? '';
const hash = chunk.hash ?? '';
nextHashes.set(key, hash);

// During first build we want to display all chunks.
// On rebuilds, skip chunks whose hash hasn't changed.
if (!isFirstRun && prevHashes.get(key) === hash) {
unchangedChunkNumber++;
continue;
}

Expand Down Expand Up @@ -199,9 +209,8 @@ function statsToString(
generateBundleStats({ ...chunk, rawSize, estimatedTransferSize })
);
}
unchangedChunkNumber = json.chunks.length - changedChunksStats.length;

runsCache.add(json.outputPath || '');
chunkHashCache.set(json.outputPath || '', nextHashes);

const statsTable = generateBuildStatsTable(
changedChunksStats,
Expand Down Expand Up @@ -421,11 +430,18 @@ export function generateBuildEventStats(

const allChunksCount = chunks.length;
const isFirstRun = !runsCache.has(rspackStats.outputPath || '');
const prevHashes =
chunkHashCache.get(rspackStats.outputPath || '') ??
new Map<string | number, string>();

const chunkFiles = new Set<string>();
for (const chunk of chunks) {
if (!isFirstRun && chunk.rendered) {
changedChunksCount++;
if (!isFirstRun) {
const key = chunk.id ?? chunk.names?.[0] ?? '';
const hash = chunk.hash ?? '';
if (prevHashes.get(key) !== hash) {
changedChunksCount++;
}
}

if (chunk.initial) {
Expand Down
Loading