fix(angular-rspack): ensure rebuild chunks emitted summary accurate#34979
Merged
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👷 Deploy request for nx-dev pending review.Visit the deploys page to approve it
|
jaysoo
approved these changes
Mar 24, 2026
Member
|
Thanks @Coly010 ! |
Contributor
|
View your CI Pipeline Execution ↗ for commit 744ff8c
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 26, 2026
…34979) ## Current Behavior Currently, rebuilds produce a summary table that is not accurate. A key difference in how Rspack sets `chunks.rendered` compared to Webpack resulted in the logic for determining rebuilt chunks to be incorrect. ## Expected Behavior Ensure the summary table for emitted chunks is accurate on rebuild ## Related Issues It does not _fully_ solve #34936, however it should be a good first step to finding out if too many chunks are being emitted (cherry picked from commit 36534a4)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, rebuilds produce a summary table that is not accurate.
A key difference in how Rspack sets
chunks.renderedcompared to Webpack resulted in the logic for determining rebuilt chunks to be incorrect.Expected Behavior
Ensure the summary table for emitted chunks is accurate on rebuild
Related Issues
It does not fully solve #34936, however it should be a good first step to finding out if too many chunks are being emitted