-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(core): project graph creation processes project dependencies correctly #32784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FrozenPandaz
merged 5 commits into
master
from
core/process-project-dependencies-correctly
Sep 26, 2025
Merged
fix(core): project graph creation processes project dependencies correctly #32784
FrozenPandaz
merged 5 commits into
master
from
core/process-project-dependencies-correctly
Sep 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit fcda2f9
☁️ Nx Cloud last updated this comment at |
23aa649 to
6600da2
Compare
213c25d to
ed6b4ad
Compare
ed6b4ad to
bac9805
Compare
bac9805 to
76472dc
Compare
76472dc to
7174af3
Compare
9fa7e70 to
9e9f6f8
Compare
9e9f6f8 to
fb4ea48
Compare
f508051 to
2ea6bab
Compare
comp615
reviewed
Sep 24, 2025
packages/nx/src/plugins/js/project-graph/build-dependencies/target-project-locator.ts
Outdated
Show resolved
Hide resolved
11617ee to
dc6f6c7
Compare
dc6f6c7 to
9c4b611
Compare
9c4b611 to
3d95a70
Compare
3d95a70 to
8f283fe
Compare
8f283fe to
6ef92aa
Compare
6ef92aa to
fcda2f9
Compare
FrozenPandaz
approved these changes
Sep 26, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The project graph build process incorrectly handles dependencies when workspace projects have
different versions or are referenced via specific version ranges. This causes several issues:
(which don't have versions)
"proj4": "1.0.0" when workspace has "version": "2.0.0") incorrectly resolve to the workspace
project instead of the installed npm package
Expected Behavior
The dependency resolution should:
referenced
wildcards
Notes
This has inadvertently caused issues when calculating which manifest files need to be updated in the JSVersionActions / Nx Release for Npm Packages
Related Issues
Fixes #31454