fix(core): npm-parser should handle symlinked nested deps for workspaces

Author: Coly010

packages/nx/src/plugins/js/lock-file/npm-parser.ts

@@ -116,7 +116,10 @@ function getNodes(
 
       const packageName = path.split('node_modules/').pop();
       const version = findV3Version(snapshot, packageName);
-      createNode(packageName, version, path, nodes, keyMap, snapshot);
+      // symlinked packages in workspaces do not have versions
+      if (version) {
+        createNode(packageName, version, path, nodes, keyMap, snapshot);
+      }
     });
   } else {
     Object.entries(data.dependencies).forEach(([packageName, snapshot]) => {

packages/nx/src/plugins/package-json/create-nodes.spec.ts

@@ -60,6 +60,7 @@ describe('nx package.json workspaces plugin', () => {
                 "packageExports": undefined,
                 "packageMain": undefined,
                 "packageName": "root",
+                "packageVersion": undefined,
               },
               "targetGroups": {
                 "NPM Scripts": [
@@ -113,6 +114,7 @@ describe('nx package.json workspaces plugin', () => {
                 "packageExports": undefined,
                 "packageMain": undefined,
                 "packageName": "lib-a",
+                "packageVersion": undefined,
               },
               "targetGroups": {
                 "NPM Scripts": [
@@ -173,6 +175,7 @@ describe('nx package.json workspaces plugin', () => {
                 "packageExports": undefined,
                 "packageMain": undefined,
                 "packageName": "lib-b",
+                "packageVersion": undefined,
               },
               "targetGroups": {
                 "NPM Scripts": [
@@ -282,6 +285,7 @@ describe('nx package.json workspaces plugin', () => {
                       "packageExports": undefined,
                       "packageMain": undefined,
                       "packageName": "vite",
+                      "packageVersion": undefined,
                     },
                     "targetGroups": {},
                   },
@@ -385,6 +389,7 @@ describe('nx package.json workspaces plugin', () => {
                       "packageExports": undefined,
                       "packageMain": undefined,
                       "packageName": "vite",
+                      "packageVersion": undefined,
                     },
                     "targetGroups": {},
                   },
@@ -484,6 +489,7 @@ describe('nx package.json workspaces plugin', () => {
                       "packageExports": undefined,
                       "packageMain": undefined,
                       "packageName": "vite",
+                      "packageVersion": undefined,
                     },
                     "targetGroups": {},
                   },
@@ -567,6 +573,7 @@ describe('nx package.json workspaces plugin', () => {
                       "packageExports": undefined,
                       "packageMain": undefined,
                       "packageName": "root",
+                      "packageVersion": undefined,
                     },
                     "targetGroups": {
                       "NPM Scripts": [
@@ -650,6 +657,7 @@ describe('nx package.json workspaces plugin', () => {
                       "packageExports": undefined,
                       "packageMain": undefined,
                       "packageName": "root",
+                      "packageVersion": undefined,
                     },
                     "targetGroups": {
                       "NPM Scripts": [
@@ -740,6 +748,7 @@ describe('nx package.json workspaces plugin', () => {
                       "packageExports": undefined,
                       "packageMain": undefined,
                       "packageName": "root",
+                      "packageVersion": undefined,
                     },
                     "targetGroups": {},
                   },
@@ -921,6 +930,7 @@ describe('nx package.json workspaces plugin', () => {
                     },
                     "packageMain": undefined,
                     "packageName": "lib-a",
+                    "packageVersion": undefined,
                   },
                   "targetGroups": {
                     "NPM Scripts": [
@@ -971,6 +981,7 @@ describe('nx package.json workspaces plugin', () => {
                     },
                     "packageMain": undefined,
                     "packageName": "lib-b",
+                    "packageVersion": undefined,
                   },
                   "targetGroups": {
                     "NPM Scripts": [