Skip to content

fix(vite): add tslib as a dep for @nx/vite and remove @swc/helpers #32341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

fix(vite): add tslib as a dep for @nx/vite and remove @swc/helpers #32341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/angular-rspack-compiler/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"@nx/dependency-checks": [
"error",
{
"buildTargets": ["build-base"],
"ignoredFiles": [
"{projectRoot}/.eslintrc.json",
"{projectRoot}/vite.config.{js,ts,mjs,mts}"
Expand All @@ -45,8 +46,7 @@
"@angular/core",
"jsonc-eslint-parser",
"vitest",
"memfs",
"tslib"
"memfs"
]
}
]
Expand Down
2 changes: 1 addition & 1 deletion packages/angular-rspack/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"@nx/dependency-checks": [
"error",
{
"buildTargets": ["build-base"],
"ignoredFiles": [
"{projectRoot}/.eslintrc.json",
"{projectRoot}/vite.config.{js,ts,mjs,mts}"
Expand All @@ -46,7 +47,6 @@
"jsonc-eslint-parser",
"vitest",
"memfs",
"tslib",
// it's only a type import, so it won't be required at runtime
"sass",
// shown as unused because it's required using `createRequire`
Expand Down
1 change: 0 additions & 1 deletion packages/angular/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"@angular-devkit/architect",
"@angular-devkit/schematics",
"@nx/cypress",
Expand Down
2 changes: 1 addition & 1 deletion packages/create-nx-plugin/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"error",
{
"buildTargets": ["build-base"],
"ignoredDependencies": ["tslib"]
"ignoredDependencies": []
}
]
}
Expand Down
2 changes: 1 addition & 1 deletion packages/create-nx-workspace/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"error",
{
"buildTargets": ["build-base"],
"ignoredDependencies": ["tslib"]
"ignoredDependencies": []
}
]
}
Expand Down
1 change: 0 additions & 1 deletion packages/cypress/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"typescript",
// Type imports only
Expand Down
2 changes: 1 addition & 1 deletion packages/detox/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"error",
{
"buildTargets": ["build-base"],
"ignoredDependencies": ["nx", "tslib", "typescript", "detox"]
"ignoredDependencies": ["nx", "typescript", "detox"]
}
]
}
Expand Down
1 change: 0 additions & 1 deletion packages/devkit/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
"nx",
"typescript",
"prettier",
"tslib",
// Installed to workspace by plugins
"rxjs",
"@angular-devkit/core",
Expand Down
2 changes: 1 addition & 1 deletion packages/esbuild/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"error",
{
"buildTargets": ["build-base"],
"ignoredDependencies": ["nx", "tslib", "typescript", "esbuild"]
"ignoredDependencies": ["nx", "typescript", "esbuild"]
}
]
}
Expand Down
1 change: 0 additions & 1 deletion packages/eslint-plugin/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"typescript",
// Installed to workspace by plugins
Expand Down
1 change: 0 additions & 1 deletion packages/eslint/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"@nx/jest",
"typescript",
Expand Down
1 change: 0 additions & 1 deletion packages/expo/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"@nx/jest",
"@nx/rollup",
Expand Down
1 change: 0 additions & 1 deletion packages/express/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"@nx/eslint",
"typescript",
Expand Down
2 changes: 1 addition & 1 deletion packages/gradle/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@nx/dependency-checks": [
"error",
{
"ignoredDependencies": ["nx", "tslib"]
"ignoredDependencies": ["nx"]
}
]
}
Expand Down
1 change: 0 additions & 1 deletion packages/jest/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"typescript",
"prettier",
Expand Down
1 change: 0 additions & 1 deletion packages/js/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"prettier",
"typescript",
Expand Down
1 change: 0 additions & 1 deletion packages/module-federation/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"eslint",
"typescript",
Expand Down
1 change: 0 additions & 1 deletion packages/nest/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"typescript",
"eslint",
Expand Down
1 change: 0 additions & 1 deletion packages/next/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"@nx/webpack",
"@nx/cypress",
Expand Down
2 changes: 1 addition & 1 deletion packages/node/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"error",
{
"buildTargets": ["build-base"],
"ignoredDependencies": ["nx", "tslib", "typescript", "@nx/webpack"]
"ignoredDependencies": ["nx", "typescript", "@nx/webpack"]
}
]
}
Expand Down
1 change: 0 additions & 1 deletion packages/nuxt/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"eslint",
"typescript",
Expand Down
1 change: 0 additions & 1 deletion packages/nx/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"typescript",
"@nrwl/angular",
Expand Down
1 change: 0 additions & 1 deletion packages/playwright/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"typescript",
"@playwright/test",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"error",
{
"buildTargets": ["build-base"],
"ignoredDependencies": ["nx", "tslib", "typescript", "eslint"]
"ignoredDependencies": ["nx", "typescript", "eslint"]
}
]
}
Expand Down
1 change: 0 additions & 1 deletion packages/react-native/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"eslint",
"prettier",
Expand Down
1 change: 0 additions & 1 deletion packages/react/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"eslint",
"prettier",
Expand Down
1 change: 0 additions & 1 deletion packages/remix/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"eslint",
"prettier",
Expand Down
1 change: 0 additions & 1 deletion packages/rollup/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"typescript",
"@swc/core", // Installed to workspace and only used in swc() plugin
Expand Down
1 change: 0 additions & 1 deletion packages/rsbuild/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"eslint",
"typescript",
Expand Down
1 change: 0 additions & 1 deletion packages/rspack/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"typescript",
// Used in require.resolve calls
Expand Down
2 changes: 1 addition & 1 deletion packages/storybook/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"error",
{
"buildTargets": ["build-base"],
"ignoredDependencies": ["nx", "tslib", "typescript", "@nx/web"]
"ignoredDependencies": ["nx", "typescript", "@nx/web"]
}
]
}
Expand Down
2 changes: 0 additions & 2 deletions packages/vite/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,9 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"typescript",
"vite",
"@swc/helpers",
// we only check if the package is installed
"eslint",
// we ensure it is installed and only use it when eslint is installed
Expand Down
2 changes: 1 addition & 1 deletion packages/vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@
"dependencies": {
"@nx/devkit": "workspace:*",
"@phenomnomnominal/tsquery": "~5.0.1",
"@swc/helpers": "~0.5.0",
"enquirer": "~2.3.6",
"@nx/js": "workspace:*",
"picomatch": "4.0.2",
"tsconfig-paths": "^4.1.2",
"semver": "^7.6.3",
"tslib": "^2.3.0",
"ajv": "^8.0.0"
},
"devDependencies": {
Expand Down
1 change: 0 additions & 1 deletion packages/vue/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"typescript",
"@nx/cypress",
Expand Down
1 change: 0 additions & 1 deletion packages/web/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
{
"buildTargets": ["build-base"],
"ignoredDependencies": [
"tslib",
"nx",
"typescript",
"eslint",
Expand Down
1 change: 0 additions & 1 deletion packages/webpack/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
"nx",
"typescript",
"eslint",
"tslib",
// Used in require.resolve calls
"@babel/core",
"css-loader",
Expand Down
1 change: 0 additions & 1 deletion packages/workspace/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
"ignoredDependencies": [
"nx",
"prettier",
"tslib",
"typescript",
"@angular-devkit/schematics",
"@angular-devkit/core",
Expand Down
6 changes: 3 additions & 3 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading