Skip to content

Conversation

@jaysoo
Copy link
Member

@jaysoo jaysoo commented Aug 13, 2025

When we switched to the TS solution setup with inferred tsc builds, we didn't update the dependencies for @nx/vite to use tslib instead of @swc/helpers. It was previously using @nx/js:swc executor, but now build-base target is inferred as tsc -b.

It did not cause issues since other packages including nx always install tslib, but technically it is incorrect, and we were ignoring the errors by adding tslib and @swc/helpers to be ignored in .eslintrc.json.

This PR also cleans up the eslint config for all other packages since we do not need to ignore tslib for @nx/dependency-checks to pass.

Current Behavior

@nx/vite is missing tslib dependency even though the built JS file uses it.

Expected Behavior

Should have tslib as a dependency and not @swc/helpers.

Related Issue(s)

Fixes #

@jaysoo jaysoo requested review from a team, FrozenPandaz and MaxKless as code owners August 13, 2025 15:00
@jaysoo jaysoo requested a review from Coly010 August 13, 2025 15:00
@nx-cloud
Copy link
Contributor

nx-cloud bot commented Aug 13, 2025

View your CI Pipeline Execution ↗ for commit e19a800

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 42m View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 2m 25s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 7s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 6s View ↗
nx documentation ✅ Succeeded 51s View ↗
nx affected -t e2e-macos-local --parallel=1 --b... ✅ Succeeded 26m 31s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-13 15:49:22 UTC

@vercel
Copy link

vercel bot commented Aug 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Updated (UTC)
nx-dev 🛑 Canceled Aug 13, 2025 3:22pm

@FrozenPandaz FrozenPandaz merged commit 0452910 into master Aug 13, 2025
7 checks passed
@FrozenPandaz FrozenPandaz deleted the NXC-2955 branch August 13, 2025 15:36
@github-actions
Copy link
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants