fix(vite): add tslib as a dep for @nx/vite and remove @swc/helpers #32341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switched to the TS solution setup with inferred
tscbuilds, we didn't update the dependencies for@nx/viteto usetslibinstead of@swc/helpers. It was previously using@nx/js:swcexecutor, but nowbuild-basetarget is inferred astsc -b.It did not cause issues since other packages including
nxalways install tslib, but technically it is incorrect, and we were ignoring the errors by addingtsliband@swc/helpersto be ignored in.eslintrc.json.This PR also cleans up the eslint config for all other packages since we do not need to ignore
tslibfor@nx/dependency-checksto pass.Current Behavior
@nx/viteis missingtslibdependency even though the built JS file uses it.Expected Behavior
Should have
tslibas a dependency and not@swc/helpers.Related Issue(s)
Fixes #