fixup: [nrf noup] ci: NCS-specific CI tweaks #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
force-pushed
the
fix_gitlint_single_commit
branch
from
f56b3b8 to
714f330
Compare
carlescufi
changed the title
carlescufi
approved these changes
Jan 16, 2023
rlubos
approved these changes
Jan 16, 2023
carlescufi
requested changes
Jan 16, 2023
carlescufi
requested changes
Jan 16, 2023
fixup! [nrf noup] ci: NCS-specific CI tweaks When merging a single commit we should be using "--commit" option of gitlint as per [1] from 0.9.0 "--commits" doesn't work for single commit causing gitlint to lint all commits in the repo. FYI, [2] fixes this issue, but it is not merged yet. [1] - https://github.com/jorisroovers/gitlint/blob/main/CHANGELOG.md#v090-2017-12-03 [2] - jorisroovers/gitlint#412 Signed-off-by: Krishna T <[email protected]>
krish2718
force-pushed
the
fix_gitlint_single_commit
branch
from
714f330 to
43e26c9
Compare
carlescufi
approved these changes
Jan 16, 2023
carlescufi
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging a single commit we should be using "--commit" option of gitlint as per [1] from 0.9.0 "--commits" doesn't work for single commit causing gitlint to lint all commits in the repo.
FYI, [2] fixes this issue, but it is not merged yet.
[1] - https://github.com/jorisroovers/gitlint/blob/main/CHANGELOG.md#v090-2017-12-03 [2] - jorisroovers/gitlint#412
Signed-off-by: Krishna T [email protected]