Skip to content

Conversation

@krish2718
Copy link
Contributor

…tion

Wi-Fi bands are regulated by a governing body depending on operating country, add support for the user to provide a country of operation as a hint to the Wi-Fi chipset.

Ideally if the chipset supports this is all handled internally, in that case "get" is useful but for testing and other usecases add a "set" as well, similar to "iw reg set" or "country_code=" configuration in hostapd/wpa_supplicant in Linux world.

This add a new offload API operation "reg_domain" that can be used to either get or set the regulatory information.

The validation is left to the underlying chipset, shell only does basic validation, (XY/00).

This is just a regulatory hint to the chipset, there could be other regulatory hints e.g., beacon that can override this configuration, so, an additional option to force this setting despite other hints is also given for testing purposes.

FYI, the standard database used is [1].

[1] - https://git.kernel.org/pub/scm/linux/kernel/git/sforshee/wireless-regdb.git/tree/db.txt

Upstream PR: zephyrproject-rtos/zephyr#53541

Signed-off-by: Krishna T [email protected]

@krish2718 krish2718 force-pushed the add_wifi_reg branch 2 times, most recently from 04bb1d1 to d8ecdf7 Compare January 13, 2023 14:39
@krish2718 krish2718 changed the title [nrf fromlist] net: wifi: Add support for regulatory domain configura… [nrf fromtree] net: wifi: Add support for regulatory domain configura… Jan 13, 2023
@krish2718
Copy link
Contributor Author

krish2718 commented Jan 14, 2023

After multiple re-runs and debugging, the problem lies with gitlint in the compliance. Due to https://github.com/jorisroovers/gitlint/blob/main/CHANGELOG.md#v090-2017-12-03 using a single commit along with --commits won't work, not sure how this got missed as this was 0.9.0 but we use 0.18.0? @carlescufi

So, this needs a fix.

@krish2718 krish2718 requested a review from carlescufi January 14, 2023 16:23
@carlescufi
Copy link
Contributor

After multiple re-runs and debugging, the problem lies with gitlint in the compliance. Due to https://github.com/jorisroovers/gitlint/blob/main/CHANGELOG.md#v090-2017-12-03 using a single commit along with --commits won't work, not sure how this got missed as this was 0.9.0 but we use 0.18.0? @carlescufi

So, this needs a fix.

It's because we just started using this and all PRs so far had more than one commit I believe

Copy link
Contributor

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the gitlint commit message so it amends:
[nrf noup] ci: NCS-specific CI tweaks

@krish2718
Copy link
Contributor Author

Depends on #1027

@krish2718 krish2718 force-pushed the add_wifi_reg branch 2 times, most recently from f1be1ef to 5fe6fd6 Compare January 16, 2023 14:49
…tion

Wi-Fi bands are regulated by a governing body depending on operating
country, add support for the user to provide a country of operation as a
hint to the Wi-Fi chipset.

Ideally if the chipset supports, this is all handled internally, in that
case "get" is useful. But for testing and other use cases add a "set" as
well, similar to "iw reg set" or "country_code=" configuration in
hostapd/wpa_supplicant in Linux world.

This add a new offload API operation "reg_domain" that can be used to
either get or set the regulatory information.

The validation is left to the underlying chipset, shell only does basic
validation (XY/00).

This is just a regulatory hint to the chipset, there could be other
regulatory hints e.g., beacon that can override this configuration, so,
an additional option to force this setting, despite other hints, is
useful for testing purposes.

FYI, the standard database used is [1].

[1] - https://git.kernel.org/pub/scm/linux/kernel/git/sforshee/wireless-regdb.git/tree/db.txt

Signed-off-by: Krishna T <[email protected]>
(cherry picked from commit fadb1fd)
@carlescufi carlescufi merged commit bcd2fc7 into nrfconnect:main Jan 16, 2023
@krish2718 krish2718 deleted the add_wifi_reg branch January 16, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants