Skip to content

fix(ui): correct show-scroll-to-top logic#2127

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
alexdln:fix/scroll-to-top-package
Mar 18, 2026
Merged

fix(ui): correct show-scroll-to-top logic#2127
danielroe merged 2 commits intonpmx-dev:mainfrom
alexdln:fix/scroll-to-top-package

Conversation

@alexdln
Copy link
Member

@alexdln alexdln commented Mar 18, 2026

🧭 Context

A small edit, as I missed the condition that scrolling only appeared on devices with touch support, but it was expected to work for all devices

Related to #2035 (comment)

@vercel
Copy link

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 18, 2026 10:37am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 18, 2026 10:37am
npmx-lunaria Ignored Ignored Mar 18, 2026 10:37am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 97d77632-6142-484b-9beb-cd78b7a4484b

📥 Commits

Reviewing files that changed from the base of the PR and between e886c99 and ca5379c.

📒 Files selected for processing (1)
  • app/components/Package/Header.vue
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/components/Package/Header.vue

📝 Walkthrough

Walkthrough

The pull request updates app/components/Package/Header.vue to stop using the isTouchDeviceClient value from the useScrollToTop composable. The showScrollToTop computed now unconditionally evaluates scrollY.value > SCROLL_TO_TOP_THRESHOLD. The component destructures only scrollToTop from useScrollToTop, removing the touch-device check from downstream logic.

Possibly related PRs

Suggested reviewers

  • danielroe
  • graphieros
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining that the touch device condition was removed from scroll-to-top logic to enable the feature for all devices.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.

Change the reviews.profile setting to assertive to make CodeRabbit's nitpick more issues in your PRs.

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Mar 18, 2026
Merged via the queue into npmx-dev:main with commit b4b9cc8 Mar 18, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants