Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/pages/package/[[org]]/[name].vue (1)
520-523: Misleading comment.The comment states "includes file path if present", but this computed property doesn't include any file path logic. This comment appears to be copy-pasted from the code view page. Consider updating it to accurately describe this URL pattern for the main package page.
✏️ Suggested fix
-// URL pattern for version selector - includes file path if present +// URL pattern for version selector const versionUrlPattern = computed( () => `/package/${pkg.value?.name || packageName.value}/v/{version}`, )
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fa7bacad-7947-4ccd-a764-4281272f9f08
📒 Files selected for processing (2)
app/pages/package-docs/[...path].vueapp/pages/package/[[org]]/[name].vue
|
I like a lot the resulting flexibility. Package name hidden on scrollFor some reason not seeing the name of the package feels to me like it removes some quality to the page, like it suddenly anonymises the content. We need to conquer real estate on mobile, but probably a solution can be found to keep it visible on desktop ? |
|
@graphieros Not only yours, and I generally agree too. There will just still be edge cases that need to be processed somehow 🫠 |
I know... 😬 |
|
@graphieros created an issue, hope we will find good option #2053 |
|
@btea hi, I reused the logic that was on the main page on all pages - the scroll appears when needed in the package header Like here - https://npmx.dev/package-code/nuxt/v/4.4.2/dist%2Fapp%2Fcomponents%2Fclient-fallback.server.js |
|
@alexdln I'm sorry, I didn't quite understand what you meant.
Accessing the page via the link you provided above, I did not see a "Scroll to Top" button (used to quickly scroll the current file's code to the top). 😕 |
|
@btea sorry, here it is. It becomes visible after scrolling for a bit |
This is very strange, I haven't been able to see the relevant button on my page. |
|
Really weird... |
|
Oh no, I think I found it - I'm not using this component (I dont know why) - I just used a button with the required logic... The component has a fallback option in case the logic isn't supported, and apparently yours isn't. So button in header don't have fallback option and that's why you don't see anything... Probably |
|
It seems to be a problem with this logic, which is causing the button not to be displayed in the PC browser. When I switched to mobile mode, the buttons were displayed correctly. |
|
Oh... I should get used that when you have a touchscreen laptop, you can get similar artifacts. Thanks a lot for finding this 🤍 |
3 participants
🔗 Linked issue
Closes #2031 Closes #2033
🧭 Context
Updated UI in the package header - more stable, more versatile, more properly separated, and with other minor updates to improve usability. Now we can quickly select a version and switch between tabs on all package pages from header.
This is a reusable component that is used on all pages in the package. This further reduces the amount of code in the pages themselves
Updated the UI for the code view page - lines and symbols have moved down, the path has moved to a panel above the code and this panel is always displayed, and a scroll bar appears for long paths (I hope we will improve it further in next prs), removed internal code scrolling and improved stickiness
Updated the UI for the diff-view page - the version selector has been moved to the right, added shortcuts for diff and main
Also fixed a bug with the version-selector in diff-view - it basically didn't work
And a couple more bugs with layout on header, nav, breadcrumbs
in one train with #2030
There are still some details to improve (for example, in this discord thread). But for now, this PR is already large and stable. We can try to implement the rest in future iterations