Skip to content

fix(ui): remove redundant back button in selection-view #2119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphieros merged 2 commits into from
Mar 17, 2026
Merged

fix(ui): remove redundant back button in selection-view #2119

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0393a0c
fix(ui): remove redundant back button in selection-view
MatteoGabriele Mar 17, 2026
1d3e625
fix: remove unused method
MatteoGabriele Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions app/components/Package/SelectionView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ defineProps<{
viewMode?: ViewMode
}>()

const { selectedPackages, clearSelectedPackages, selectedPackagesParam, closeSelectionView } =
usePackageSelection()
const { selectedPackages, clearSelectedPackages, selectedPackagesParam } = usePackageSelection()

const { data, pending } = useAsyncData(
async () => {
Expand All @@ -25,16 +24,7 @@ const { data, pending } = useAsyncData(

<template>
<section>
<header class="mb-6 flex items-center justify-between">
<button
type="button"
class="cursor-pointer inline-flex items-center gap-2 font-mono text-sm text-fg-muted hover:text-fg transition-colors duration-200 rounded focus-visible:outline-accent/70"
@click="closeSelectionView"
:aria-label="$t('nav.back')"
>
<span class="i-lucide:arrow-left rtl-flip w-4 h-4" aria-hidden="true" />
<span class="hidden sm:inline">{{ $t('nav.back') }}</span>
</button>
<header class="mb-6 flex items-center justify-end">
<div class="flex items-center gap-2">
<ButtonBase variant="secondary" @click="clearSelectedPackages">
{{ $t('filters.clear_all') }}
Expand Down
Loading